Add a system to determine what a Fossilize bucket corresponds to - #308
Merged
Conversation
For DXVK / vkd3d-proton buckets we have prior knowledge.
Contributor
|
nice additions! dumping solid QoL update for debugging captures. updating my edge builds with this, thanks for deep dive onto those topics Hans! |
HansKristian-Work
pushed a commit
that referenced
this pull request
Aug 5, 2026
PR #308 (bucket-json-system, merged via 0ae323c) added RESOURCE_BUCKET_INFO = 10 to the ResourceTag enum but did not extend cli/fossilize_list.cpp's tag_names[] array. As a result: - fossilize-list --help listed 0..9 only, hiding tag 10. - fossilize-list --tag 10 (RESOURCE_COUNT=11, so the guard tag_uint >= RESOURCE_COUNT accepts it) failed with a generic 'Failed to get hashes' log instead of listing tag 10. - fossilize-list --connectivity on a .foz containing RESOURCE_BUCKET_INFO entries hit an out-of-bounds read at tag_names[par.first] when par.first == 10. Fix by appending 'bucketInfo' to tag_names[] and adding a static_assert that sizeof(tag_names)/sizeof(tag_names[0]) == RESOURCE_COUNT. The static_assert catches the same class of drift that e4ec0c1 (2025-11-10) fixed for computePipeline, so this regression cannot recur silently. This complements PR #308 without touching database storage, the replayer, or PR #310 (roundtrip-checker, still Draft). Refs: #308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For future captures, a bucket.json is dumped alongside a bucket folder to make it possible to tie a bucket hash with a configuration.
For existing captures, a python script is added that can reverse a bucket.json file based on the filter.json and some a-priori knowledge about DXVK and vkd3d-proton.