Clang update reorder - #1201
Merged
Merged
Conversation
yalcinmelihyasin
requested review from
kocdemir,
pau-baiget,
pmuetschard,
purvisa-at-google-com,
sonakshisaxena1 and
ttanatb
September 8, 2022 14:53
kocdemir
reviewed
Sep 8, 2022
kocdemir
left a comment
kocdemir
left a comment
Collaborator
There was a problem hiding this comment.
Changes LGTM, I'll test this on different machines for any compilation issues, bugs and stability.
Removes some go_repository rules for things AGI doesn't actually depend on.
- Add build target darmin_arm64 - Update breakpad to be compatible with
- Remove unused variable
- Remove unnecessary Windows patch
kocdemir
approved these changes
Sep 14, 2022
kocdemir
left a comment
kocdemir
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, seems to be working fine on m1 and linux. I believe we can fix the remaining issues, if there are any, after merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates a bunch of dependency, adds support for Apple M1 and switches Linux compiler from GCC-9 to Clang-12