unix: move net/if.h include - #1622
Merged
Merged
Conversation
2 tasks
bnoordhuis
approved these changes
Nov 9, 2017
This commit moves the net/if.h include into src/getaddrinfo.c to prevent AIX compilation errors. With these symbols exposed publicly, Node.js compilation failed on AIX by exposing Free(), which conflicts with another API. Refs: nodejs/node#16835 Refs: libuv#1445 PR-URL: libuv#1622 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the
net/if.hinclude intosrc/getaddrinfo.cto prevent AIX compilation errors. With these symbols exposed publicly, Node.js compilation failed on AIX by exposingFree(), which conflicts with another API.Refs: nodejs/node#16835
Refs: #1445
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/564/