feat(37782): 'declare method' quick fix for adding a private method - #37806
Merged
Nathan Shively-Sanders (sandersn) merged 5 commits intoMay 6, 2020
Merged
Conversation
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
feat/37782
branch
6 times, most recently
from
April 6, 2020 13:52
c3ac1bc to
ca56d42
Compare
…es that start from underscore
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
feat/37782
branch
from
April 10, 2020 08:08
ca56d42 to
a92f7a1
Compare
Nathan Shively-Sanders (sandersn)
added
the
For Uncommitted Bug
Nathan Shively-Sanders (sandersn)
requested review from
Andrew Casey (amcasey) and
Andrew Branch (andrewbranch)
April 15, 2020 15:11
Member
|
Oleksandr Tarasiuk (@a-tarasyuk) Thanks for tidying up the code, but I have to admit I'm having trouble figuring out what actually changed. It seems like it was already possible to add a method, public property, or private property - just not a private property? Was anything special required to light up that last scenario? |
Andrew Casey (amcasey)
left a comment
Andrew Casey (amcasey)
left a comment
Member
There was a problem hiding this comment.
Things seem generally correct, I'm just having trouble identifying the new code.
Andrew Casey (amcasey)
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37782