fix export * as default syntax - #39803
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 2 commits intoAug 10, 2020
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Member
|
[[Do not merge before Friday]] |
Daniel Rosenwasser (DanielRosenwasser)
requested review from
Ron Buckton (rbuckton) and
Nathan Shively-Sanders (sandersn)
July 29, 2020 21:30
Nathan Shively-Sanders (sandersn)
requested changes
Jul 29, 2020
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
One question.
The implementation looks reasonable to me, but Ron Buckton (@rbuckton) should definitely sign off on the emitted code before this goes in.
Ron Buckton (rbuckton)
approved these changes
Jul 29, 2020
Ron Buckton (rbuckton)
left a comment
Ron Buckton (rbuckton)
left a comment
Contributor
There was a problem hiding this comment.
The emit seems fine to me.
Contributor
Author
Maybe you need a label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39769
Fixes #39803