This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Dev Drive Insights - Prepopulate the cache directory and enable the make changes button - #3287
Merged
Branden Bonaby (bbonaby) merged 1 commit intoJun 27, 2024
Conversation
Member
|
Does it correctly creates the folder if it doesn't exist yet? |
Contributor
Author
I've recorded a video demonstrating the folder getting created if it doesn't exist yet. Dev.Insights.-.Prepopulate.cache.directory.mp4 |
Kristen Schau (krschau)
requested review from
Soham Das (SohamDas2021) and
Branden Bonaby (bbonaby)
June 24, 2024 22:28
Soham Das (SohamDas2021)
approved these changes
Jun 24, 2024
Branden Bonaby (bbonaby)
approved these changes
Jun 25, 2024
Branden Bonaby (bbonaby)
left a comment
Branden Bonaby (bbonaby)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Brandon Williams (@willibrandon)!
Vineeth Thomas Alex (vineeththomasalex)
approved these changes
Jun 26, 2024
Brandon Williams (willibrandon)
deleted the
prepopulate-devdrive-cache-file-path
branch
June 28, 2024 03:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Prepopulate the Dev Drive Insights cache directory and enable the make changes button.
References and relevant issues
Fixes #2681
Detailed description of the pull request / Additional comments
Before:
After:
Validation steps performed
PR checklist