Skip to content

Add support for platform compatibility check for windows - #1821

Merged
Kirtana Ashok (kiashok) merged 1 commit into
microsoft:mainfrom
kiashok:stableABICheck
Jul 5, 2023
Merged

Add support for platform compatibility check for windows#1821
Kirtana Ashok (kiashok) merged 1 commit into
microsoft:mainfrom
kiashok:stableABICheck

Conversation

@kiashok

@kiashok Kirtana Ashok (kiashok) commented Jun 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds does the following:

  • Adds function to check the host OS version and container image's OS version and returns true if the two OS versions are compatible.
  • Add stable ABI compat version checks. OS releases > WS2022 will be stable ABI compliant and the decision is to support latest container images for stable ABI compliant OSes. (Stable ABI is in preview mode on windows 11)

@kiashok
Kirtana Ashok (kiashok) requested a review from a team as a code owner June 21, 2023 00:37
jsturtevant
James Sturtevant (jsturtevant) reviewed Jun 21, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go Outdated
Comment thread osversion/platform_compat_windows.go Outdated
Comment thread osversion/platform_compat_windows.go Outdated
@kiashok
Kirtana Ashok (kiashok) force-pushed the stableABICheck branch 3 times, most recently from 5bb3091 to 9a54249 Compare June 21, 2023 22:49
jsturtevant
James Sturtevant (jsturtevant) reviewed Jun 21, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows_test.go Outdated
kevpar
Kevin Parsons (kevpar) reviewed Jun 23, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go Outdated
kevpar
Kevin Parsons (kevpar) reviewed Jun 23, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go Outdated
kevpar
Kevin Parsons (kevpar) reviewed Jun 23, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows_test.go Outdated
kevpar
Kevin Parsons (kevpar) reviewed Jun 23, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go Outdated
kevpar
Kevin Parsons (kevpar) reviewed Jun 23, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go Outdated
kevpar
Kevin Parsons (kevpar) reviewed Jun 23, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go Outdated
jterry75
Justin (jterry75) reviewed Jun 26, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows_test.go Outdated
jterry75
Justin (jterry75) reviewed Jun 26, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go Outdated
kevpar
Kevin Parsons (kevpar) reviewed Jun 27, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go Outdated
kevpar
Kevin Parsons (kevpar) reviewed Jun 27, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go Outdated
@kiashok
Kirtana Ashok (kiashok) force-pushed the stableABICheck branch 2 times, most recently from 162f281 to 5008c39 Compare June 27, 2023 19:39
kevpar
Kevin Parsons (kevpar) approved these changes Jun 29, 2023
View reviewed changes

@kevpar Kevin Parsons (kevpar) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jterry75

Justin (jterry75) commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Ok last comment lolz. AreHostAndGuest is why this sounds like virtualization API IMO. The process container is not a Guest in my head. But I'm not 100% sure what to call it that is a short name. Its really more like CanHostRunUserSpaceVersion(hostVer, containerVer). Maybe you can think of a better name but otherwise LGTM

@kiashok

Kirtana Ashok (kiashok) commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

Ok last comment lolz. AreHostAndGuest is why this sounds like virtualization API IMO. The process container is not a Guest in my head. But I'm not 100% sure what to call it that is a short name. Its really more like CanHostRunUserSpaceVersion(hostVer, containerVer). Maybe you can think of a better name but otherwise LGTM

Does CheckHostAndContainerCompat() sound ok to you?

@jterry75

Justin (jterry75) commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Ack sounds great!

@kiashok
Add support for platform compatibility check for windows
b9eb75d 
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@kiashok

Kirtana Ashok (kiashok) commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

Ack sounds great!

Justin (@jterry75) pushed new changes. Could you please sign off if it looks good?

katiewasnothere
Kathryn Baldauf (katiewasnothere) reviewed Jul 3, 2023
View reviewed changes
Comment thread osversion/platform_compat_windows.go
katiewasnothere
Kathryn Baldauf (katiewasnothere) approved these changes Jul 5, 2023
View reviewed changes

@katiewasnothere Kathryn Baldauf (katiewasnothere) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiashok
Kirtana Ashok (kiashok) merged commit 640a560 into microsoft:main Jul 5, 2023
@kiashok Kirtana Ashok (kiashok) mentioned this pull request Jul 5, 2023
Merged
Kirtana Ashok (kiashok) added a commit to kiashok/hcsshim that referenced this pull request Jul 20, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
5f66cfb 
)

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Kirtana Ashok (kiashok) added a commit to kiashok/hcsshim that referenced this pull request Jul 20, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
47a111a 
)

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Kirtana Ashok (kiashok) added a commit to kiashok/hcsshim that referenced this pull request Jul 20, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
4bcd148 
)

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Kirtana Ashok (kiashok) added a commit that referenced this pull request Jul 20, 2023
@kiashok
[release/0.9] Add support for platform compatibility check for window…
9cd2a01 
…s + add windows builds (#1843)

* Add windows versions to windows builds

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>

* Add support for platform compatibility check for windows (#1821)

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>

---------

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@kiashok Kirtana Ashok (kiashok) mentioned this pull request Aug 1, 2023
Closed
Kirtana Ashok (kiashok) added a commit to kiashok/hcsshim that referenced this pull request Aug 29, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
cc4f8c5 
)

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Kirtana Ashok (kiashok) added a commit to kiashok/hcsshim that referenced this pull request Aug 31, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
ba0d4c1 
)

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Kirtana Ashok (kiashok) added a commit to kiashok/hcsshim that referenced this pull request Sep 1, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
90c0726 
)

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Kirtana Ashok (kiashok) added a commit to kiashok/hcsshim that referenced this pull request Sep 1, 2023
@kiashok
Add support for platform compatibility check for windows (microsoft#1821
439e2dd 
)

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
(cherry picked from commit 640a560)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Kirtana Ashok (kiashok) added a commit that referenced this pull request Sep 6, 2023
@kiashok
Add support for platform compatibility check for windows (#1821) (#1878)
750e11b 
(cherry picked from commit 640a560)

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jterry75 Justin (jterry75) jterry75 left review comments
+3 more reviewers
@jsturtevant James Sturtevant (jsturtevant) jsturtevant left review comments
@kevpar Kevin Parsons (kevpar) kevpar approved these changes
@katiewasnothere Kathryn Baldauf (katiewasnothere) katiewasnothere approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kiashok @jterry75 @kevpar @jsturtevant @katiewasnothere