Skip to content

Don't depend on typescript protocol.d.ts - #163365

Merged
Matt Bierner (mjbvz) merged 1 commit into
microsoft:mainfrom
jakebailey:remove-protocol-dts
Oct 12, 2022
Merged

Don't depend on typescript protocol.d.ts#163365
Matt Bierner (mjbvz) merged 1 commit into
microsoft:mainfrom
jakebailey:remove-protocol-dts

Conversation

@jakebailey

@jakebailey Jake Bailey (jakebailey) commented Oct 11, 2022

Copy link
Copy Markdown
Member

For TS 5.0, we're making some major build changes and package cleanups stemming from our conversion from namespaces to modules. protocol.d.ts is one file I'm trying to eliminate, as it's tricky to produce in the new build. See also:

Rather than using this a d.ts file, we can depend on the same namespace as exported by tsserverlibrary instead, a file that is definitely not going away.

This actually reveals a couple of interesting things:

  • The ambient protocol namespace was being used in a couple places where it shouldn't have been.
  • Two types needed to be reexported via the protocol, implying that our protocol is not self-contained. That's something to address on the TS side, but nothing new.

@mjbvz
Matt Bierner (mjbvz) merged commit 07b8740 into microsoft:main Oct 12, 2022
@mjbvz

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants