Skip to content

added voice chat listening duration feature - #197801

Merged
Benjamin Pasero (bpasero) merged 7 commits into
microsoft:mainfrom
PrathamLalwani:main
Nov 10, 2023
Merged

added voice chat listening duration feature#197801
Benjamin Pasero (bpasero) merged 7 commits into
microsoft:mainfrom
PrathamLalwani:main

Conversation

@PrathamLalwani

@PrathamLalwani PrathamLalwani commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

I added the requested feature to either disable or increase the length of voice input duration, for this issue #197464.

image

Although I have implemented the said feature I couldn't have tested it because there is no microphone option when building locally.

@PrathamLalwani

Copy link
Copy Markdown
Contributor Author

PrathamLalwani please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Comment thread src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts Outdated
Comment thread src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts Outdated
Comment thread src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts Outdated
@PrathamLalwani

Copy link
Copy Markdown
Contributor Author

I have changed the mentioned lines and I have done it so in a way that in future more options can be added easily.

@bpasero Benjamin Pasero (bpasero) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bpasero
Benjamin Pasero (bpasero) merged commit 358b12e into microsoft:main Nov 10, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants