feat: add languageDiagnosticsService option for nes/inline completion provider - #317678
Merged
Ulugbek Abdullaev (ulugbekna) merged 3 commits intoMay 26, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the @vscode/chat-lib node entrypoint so external embedders can inject their own ILanguageDiagnosticsService, enabling NES and inline completions to enrich prompts with diagnostics from a host-provided source instead of always using the default test/in-memory implementation.
Changes:
- Added optional
languageDiagnosticsServicetoINESProviderOptions. - Added optional
languageDiagnosticsServicetoIInlineCompletionsProviderOptions. - Updated both service setup paths to register
ILanguageDiagnosticsServicefrom options when provided, otherwise fall back toTestLanguageDiagnosticsService.
Alex Ross (alexr00)
assigned
Ulugbek Abdullaev (ulugbekna) and unassigned
Alex Ross (alexr00)
Ulugbek Abdullaev (ulugbekna)
approved these changes
May 26, 2026
Alexandru Dima (alexdima)
approved these changes
May 26, 2026
Ulugbek Abdullaev (ulugbekna)
merged commit May 26, 2026
b9b3ede
into
microsoft:main
25 checks passed
Contributor
|
Christof Marti (@chrmarti) , I reviewed because was asked to, but can also let you take these if you prefer since you authored this code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional languageDiagnosticsService to INESProviderOptions and IInlineCompletionsProviderOptions, allowing external embedders of @vscode/chat-lib to provide their own diagnostics source for NES and inline completion requests.