Skip to content

first version support nette mailer for send tracy mail - #299

Closed
geniv wants to merge 1 commit into
nette:masterfrom
geniv:develop
Closed

first version support nette mailer for send tracy mail#299
geniv wants to merge 1 commit into
nette:masterfrom
geniv:develop

Conversation

@geniv

@geniv geniv commented May 14, 2018

Copy link
Copy Markdown
Contributor

prepare to mailer support for send

@dg

dg commented May 14, 2018

Copy link
Copy Markdown
Member

Thanks!

dg pushed a commit that referenced this pull request May 16, 2018
@dg
dg force-pushed the master branch 2 times, most recently from 9cfa3aa to e3a251b Compare May 16, 2018 12:33
@dg dg closed this May 16, 2018
@f3l1x

f3l1x commented May 16, 2018

Copy link
Copy Markdown
Member

@dg Should not be the mailer optional? What if you don't have it in your app?

@dg

dg commented May 16, 2018

Copy link
Copy Markdown
Member

You must enable it via option 'netteMailer' in config.

@geniv

geniv commented May 16, 2018

Copy link
Copy Markdown
Contributor Author

@dg @f3l1x this resolve setter setMailer(IMaliler)

->setClass('Tracy\ILogger')
->setFactory('Tracy\Debugger::getLogger');
->setFactory('Tracy\Debugger::getLogger')
->addSetup('setMailer', [$builder->getDefinition('mail.mailer')]);

@f3l1x f3l1x May 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg Where is the option netteMailer? :-)

@geniv geniv May 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f3l1x oh, ofcourse, in tracy extension missing setting to other mail system...

@f3l1x

f3l1x commented May 16, 2018

Copy link
Copy Markdown
Member

I am maybe stupid, but setMailer has required argument IMailer. There's no netteMailer options in extension's defaults. It looks like it force you to have IMailer registered in services, otherwise there'll be uncomplete dependency. Don't be?

@dg

dg commented May 16, 2018

Copy link
Copy Markdown
Member

I did not merge this PR as it was. Merged was 48118da

@f3l1x

f3l1x commented May 16, 2018

Copy link
Copy Markdown
Member

I see. That's it ;-) Thank you.

@geniv

geniv commented May 16, 2018

Copy link
Copy Markdown
Contributor Author

Nice! 👍

dg pushed a commit that referenced this pull request May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants