Arrays: added wrap() method - #180

milo · 2018-12-07T12:57:07Z

new feature
BC break? no
doc PR: will

I'm using such conctruction quite often, maybe I'm not the only one.

milo · 2018-12-10T10:37:44Z

Maybe implement it by

count($arr) ? ($prefix . implode($suffix . $glue . $prefix, $arr) . $suffix) : '';

but crucial is an API. No need for array count condition and prefix/suffix on single place.

dg · 2019-10-21T19:49:02Z

What about method wrap($arr, $prefix, $suffix)? And than combine implode with wrap?

milo · 2021-01-11T09:27:41Z

Sure, wrap() is better approach. Updated.

Not sure about type casting everything to string.

dg · 2021-01-11T13:16:54Z

Great

milo · 2021-01-11T16:52:00Z

Thank you!

milo force-pushed the array-implode branch from 2a60349 to 36bb5b5 Compare December 7, 2018 12:58

milo pushed a commit to milo/nette-utils that referenced this pull request Dec 7, 2018

Arrays: added implode() method (nette#180)

36bb5b5

dg force-pushed the master branch 7 times, most recently from 1d615d6 to ec1e405 Compare February 5, 2019 21:43

dg force-pushed the master branch 10 times, most recently from 5c076fd to 0b71017 Compare March 17, 2019 13:59

dg force-pushed the master branch from a0536fa to 0eb518d Compare July 1, 2019 14:11

dg force-pushed the master branch 2 times, most recently from 3ad8f46 to c133e18 Compare October 21, 2019 20:42

dg force-pushed the master branch from 771e1d9 to f1dc085 Compare November 3, 2019 10:46

dg force-pushed the master branch 5 times, most recently from 4ed28bc to 7331c07 Compare November 19, 2019 21:02

dg force-pushed the master branch 24 times, most recently from 7a06e79 to fbb0693 Compare January 20, 2020 18:30

dg and others added 2 commits January 5, 2021 23:56

added Callback::invokeAll()

3d71c31

Arrays: added wrap() method (nette#180)

085555e

dependabot Bot mentioned this pull request Mar 16, 2021

Bump nette/utils from 3.2.1 to 3.2.2 in /issue-bot Korbeil/phpstan#5

Closed

Navigation Menu

Uh oh!

Uh oh!

Arrays: added wrap() method - #180