Hash#inspect with colon style - #10924
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
tompng
force-pushed
the
hash_colon_style_inspect
branch
3 times, most recently
from
June 7, 2024 16:21
de3bb45 to
898f9cb
Compare
tompng
force-pushed
the
hash_colon_style_inspect
branch
2 times, most recently
from
June 14, 2024 14:13
75adf8f to
aaa8d8c
Compare
ko1
removed their request for review
July 19, 2024 01:07
tompng
force-pushed
the
hash_colon_style_inspect
branch
from
July 24, 2024 17:20
aaa8d8c to
a6c54d5
Compare
This was referenced Jul 24, 2024
tompng
force-pushed
the
hash_colon_style_inspect
branch
3 times, most recently
from
August 15, 2024 17:13
d6475a1 to
49e6761
Compare
Member
Author
|
test-bundled-gems (debug) still fails but it is because debug(tag=v1.9.2) does not contain fixed test code yet. |
tompng
force-pushed
the
hash_colon_style_inspect
branch
from
September 1, 2024 14:28
49e6761 to
998fdb3
Compare
tompng
force-pushed
the
hash_colon_style_inspect
branch
from
September 20, 2024 14:39
998fdb3 to
3b3adec
Compare
mame
force-pushed
the
hash_colon_style_inspect
branch
from
October 3, 2024 07:30
3b3adec to
f74a5ae
Compare
tompng
force-pushed
the
hash_colon_style_inspect
branch
from
October 3, 2024 09:19
f74a5ae to
71c2b08
Compare
mame
enabled auto-merge (rebase)
October 3, 2024 09:20
st0012
added a commit
to ruby/rdoc
that referenced
this pull request
Oct 3, 2024
4 tasks
tompng
added a commit
to tompng/error_highlight
that referenced
this pull request
Oct 3, 2024
Apply changes in ruby/ruby#10924
tompng
added a commit
to tompng/pp
that referenced
this pull request
Oct 3, 2024
Apply changes in ruby/ruby#10924
mame
pushed a commit
to ruby/error_highlight
that referenced
this pull request
Oct 3, 2024
Apply changes in ruby/ruby#10924
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Oct 3, 2024
One isn't because of Ruby, but the source location of the route is different based on the Ruby version. So by normalizing the `rails routes` output we make the test more resilient. The other is that `Hash#inspect` just changed in ruby-head ruby/ruby#10924
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Oct 3, 2024
One isn't because of Ruby, but the source location of the route is different based on the Ruby version. So by normalizing the `rails routes` output we make the test more resilient. The other is that `Hash#inspect` just changed in ruby-head ruby/ruby#10924
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Oct 3, 2024
One isn't because of Ruby, but the source location of the route is different based on the Ruby version. So by normalizing the `rails routes` output we make the test more resilient. The other is that `Hash#inspect` just changed in ruby-head ruby/ruby#10924
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Oct 3, 2024
One isn't because of Ruby, but the source location of the route is different based on the Ruby version. So by normalizing the `rails routes` output we make the test more resilient. The other is that `Hash#inspect` just changed in ruby-head ruby/ruby#10924
6 tasks
byroot
added a commit
to byroot/rails
that referenced
this pull request
Oct 5, 2024
byroot
added a commit
to byroot/rails
that referenced
this pull request
Oct 5, 2024
byroot
added a commit
to byroot/rails
that referenced
this pull request
Oct 5, 2024
byroot
added a commit
to byroot/rails
that referenced
this pull request
Oct 5, 2024
byroot
added a commit
to byroot/rails
that referenced
this pull request
Oct 5, 2024
byroot
added a commit
to byroot/rails
that referenced
this pull request
Oct 5, 2024
byroot
added a commit
to byroot/rails
that referenced
this pull request
Oct 5, 2024
byroot
added a commit
to byroot/rails
that referenced
this pull request
Oct 5, 2024
Ref: ruby/ruby#10924 Ref: https://bugs.ruby-lang.org/issues/20433 Followup: rails#53202 A few were missed.
byroot
added a commit
to rails/rails
that referenced
this pull request
Oct 5, 2024
Ref: https://bugs.ruby-lang.org/issues/20433 Followup: #53202 A few were missed.
byroot
added a commit
to rails/rails
that referenced
this pull request
Oct 5, 2024
Ref: https://bugs.ruby-lang.org/issues/20433 Followup: #53202 A few were missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements https://bugs.ruby-lang.org/issues/20433#note-7
Change Hash#inspect to use colon style if the key is a symbol.
When key is not a symbol, space is added around
=>Symbol key that needs quote can be determined by this