Some internal rustdoc links broke

[tesuji]

rust/library/alloc/src/vec/spec_from_iter_nested.rs

Line 8 in dcf622e

/// see [`SpecFromIter`] for details.

warning: unresolved link to `SpecFromIter`
 --> library/alloc/src/vec/spec_from_iter_nested.rs:8:10
  |
8 | /// see [`SpecFromIter`] for details.
  |          ^^^^^^^^^^^^^^ no item named `SpecFromIter` in scope
  |
  = note: `#[warn(broken_intra_doc_links)]` on by default
  = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

And in stdarch submodule:

warning: unresolved link to `B,W`
   --> library/std/src/../../stdarch/crates/std_detect/src/detect/macros.rs:57:19
    |
57  |                   $(#[$feature_comment])*
    |                     ^^^^^^^^^^^^^^^^^^^
    | 
   ::: library/std/src/../../stdarch/crates/std_detect/src/detect/arch/x86.rs:18:1
    |
18  | / features! {
19  | |     @TARGET: x86;
20  | |     @MACRO_NAME: is_x86_feature_detected;
21  | |     @MACRO_ATTRS:
...   |
195 | |     /// RTM, Intel (Restricted Transactional Memory)
196 | | }
    | |_- in this macro invocation
    |
    = note: `#[warn(broken_intra_doc_links)]` on by default
    = note: the link appears in this line:
            
            AVX-512 BITALG (Support for VPOPCNT[B,W] and VPSHUFBITQMB)
                                                ^^^
    = note: no item named `B,W` in scope
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
    = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

@rustbot label: T-rustdoc C-bug E-easy

[jyn514]

@lzutao those warnings are denied on CI, so they shouldn't ever be happening. How did you compile the standard library?

[tesuji]

I pass --document-private-items flag to rustdoc. Maybe this helps emitting these errors
when the doc are not build in normal cases.

[jyn514]

I still can't reproduce:

> RUSTDOCFLAGS=--document-private-items x.py doc --stage 0 library/std
 Documenting std v0.0.0 (/home/joshua/rustc3/library/std)
    Finished release [optimized + debuginfo] target(s) in 7.54s

Can you please post the full command line you're using?

[tesuji]

If that helps, sure:

STD_DATE=$(rustc -Vv | grep commit-date | awk '{print $2}')
export RUSTDOCFLAGS="--document-private-items --crate-version \"${STD_DATE}\" --html-in-header ${PWD}/in-head.html"
cargo doc --manifest-path library/std/Cargo.toml

[jyn514]

I can reproduce with that, thanks.

I looked at the code that's failing and I'm surprised it worked with my RUSTDOCFLAGS command, SpecFromIter isn't in scope at all. It should be an easy fix, just use super::SpecFromIter instead.

[CPerezz]

Happy to fix that if hasn't been addressed yet.

@rustbot claim