Skip to content

Add manual Sync impl for ReentrantLockGuard - #125527

Merged
bors merged 1 commit into
rust-lang:masterfrom
programmerjake:patch-2
May 25, 2024
Merged

Add manual Sync impl for ReentrantLockGuard#125527
bors merged 1 commit into
rust-lang:masterfrom
programmerjake:patch-2

Conversation

@programmerjake

@programmerjake programmerjake commented May 24, 2024

Copy link
Copy Markdown
Member

Fixes: #125526
Tracking Issue: #121440

this impl is even shown in the summary in the tracking issue, but apparently was forgotten in the actual implementation

@rustbot

rustbot commented May 24, 2024

Copy link
Copy Markdown
Collaborator

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 24, 2024
@workingjubilee

Copy link
Copy Markdown
Member

@programmerjake Can you add a test for this? Something that fails to compile if ReentrantLock is not Sync, like I added in #125392

Or something that fails to compile if ReentrantLock is !Sync or ?Sync, if you're feeling silly, that's fine too.

@programmerjake

Copy link
Copy Markdown
Member Author

@workingjubilee

@programmerjake Can you add a test for this? Something that fails to compile if ReentrantLock is not Sync

done, except that this checks ReentrantLockGuard, not ReentrantLock.

@workingjubilee

Copy link
Copy Markdown
Member

ah, yes, I did... 🙃 thank you for doing what I meant instead of what I managed to say.

@workingjubilee

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 25, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit f4b9ac6 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2024
@workingjubilee

workingjubilee commented May 25, 2024

Copy link
Copy Markdown
Member

cc @joboet just so you're aware.

@workingjubilee

Copy link
Copy Markdown
Member

@bors rollup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReentrantLockGuard's Sync impl is unsound

4 participants