Skip to content

Back MoveData's location maps with a shared DenseLocationMap - #160572

Draft
xmakro wants to merge 1 commit into
rust-lang:mainfrom
xmakro:perf/move-data-dense-location-map
Draft

Back MoveData's location maps with a shared DenseLocationMap#160572
xmakro wants to merge 1 commit into
rust-lang:mainfrom
xmakro:perf/move-data-dense-location-map

Conversation

@xmakro

@xmakro xmakro commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

cleanup, suggested by @cjgillot in #160245 (comment)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2026
@mu001999

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 10, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 10, 2026
…try>

Back MoveData's location maps with a shared DenseLocationMap
@rust-bors

rust-bors Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: a0028bb (a0028bb090f8b585ad0360ba7886aac401184c29)
Base parent: 969b803 (969b803cbe1d4499f841ae0a49c637d8c70a0458)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a0028bb): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.3% [0.3%, 0.3%] 5
Regressions ❌
(secondary)
0.3% [0.2%, 0.4%] 9
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.3%, 0.3%] 5

Max RSS (memory usage)

Results (secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [0.5%, 9.6%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.7% [-4.9%, -0.4%] 11
All ❌✅ (primary) - - 0

Cycles

Results (primary 2.2%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [2.0%, 2.3%] 3
Regressions ❌
(secondary)
1.1% [0.6%, 2.5%] 17
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-2.5%, -0.4%] 11
All ❌✅ (primary) 2.2% [2.0%, 2.3%] 3

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.441s -> 459.465s (0.22%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants