extern "custom": add tests - #160805
Merged
rust-bors[bot] merged 2 commits intoAug 10, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
folkertdev
commented
Aug 9, 2026
| unsafe extern "custom" fn return_alias_unit() -> UnitAlias { | ||
| //~^ ERROR invalid signature for `extern "custom"` function | ||
| std::arch::naked_asm!("") | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is just locking in the status quo, we can update it if we decide to change that.
Contributor
There was a problem hiding this comment.
Mind putting that in a comment? So it doesn't look like we're intentionally rejecting it
tgross35
approved these changes
Aug 9, 2026
| unsafe extern "custom" fn return_alias_unit() -> UnitAlias { | ||
| //~^ ERROR invalid signature for `extern "custom"` function | ||
| std::arch::naked_asm!("") | ||
| } |
Contributor
There was a problem hiding this comment.
Mind putting that in a comment? So it doesn't look like we're intentionally rejecting it
folkertdev
force-pushed
the
extern-custom-more-tests
branch
from
August 9, 2026 20:34
98a35f2 to
da0920b
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 9, 2026
…s, r=tgross35 `extern "custom"`: add tests tracking issue: rust-lang#140829 r? tgross35
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 10, 2026
Rollup of 7 pull requests Successful merges: - #160533 (dirfd dir operations (3/4)) - #160675 (bootstrap: Remove `PATH_REMAP` from command-line selector handling ) - #160807 (Update rustc crate rkyv to 0.8.18) - #160560 (Add nightly-only support for Cargo unremap trim-paths files in `rust-gdb`) - #160804 (Change .expect message on net/parser to follow precondition style) - #160805 (`extern "custom"`: add tests) - #160816 (Mark const ptr methods and free functions as inline(always) to match *mut)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 10, 2026
Rollup of 11 pull requests Successful merges: - #160675 (bootstrap: Remove `PATH_REMAP` from command-line selector handling ) - #160807 (Update rustc crate rkyv to 0.8.18) - #159690 (Clarify `--remap-path-scope` impact on `rustc` metadata) - #160560 (Add nightly-only support for Cargo unremap trim-paths files in `rust-gdb`) - #160608 (normalization rework: clean up projection_ty_core) - #160785 (Get rid of LLM disclosure checkboxes) - #160804 (Change .expect message on net/parser to follow precondition style) - #160805 (`extern "custom"`: add tests) - #160816 (Mark const ptr methods and free functions as inline(always) to match *mut) - #160820 (Stabilize fs_set_times) - #160826 (Rename parse_delimited_token_tree in cfg_select)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #140829
r? tgross35