Optimize offset_from_unsigned result bounds - #161063
Conversation
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
r? libs |
|
Seems reasonable. For lack of any niche-type APIs that represent this, it should be okay to add this assumption. @bors r+ |
…unsigned-bound, r=clarfonthey Optimize offset_from_unsigned result bounds Hint that result cannot be larger than isize max
…unsigned-bound, r=clarfonthey Optimize offset_from_unsigned result bounds Hint that result cannot be larger than isize max
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #161089 (comment) @bors try jobs=test-various |
|
This pull request was unapproved. This PR was contained in a rollup (#161092), which was unapproved. |
This comment has been minimized.
This comment has been minimized.
…und, r=<try> Optimize offset_from_unsigned result bounds try-job: test-various
|
💔 Test for f4b1164 failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Not sure if spurious, will have to take a closer look later. |
Hint that result cannot be larger than isize max