So many warnings in `pytest -Wall`

[simonw]

First reported against the LLM test suite here:

• file handle leaks in models.py code for attachments llm#1312

Run this:

uv run pytest -Wall

Output: https://gist.github.com/simonw/15b70ba7f59b1750d8397d899c7b2bdc

[simonw]

Claude Code fixed a TON of these: https://gistpreview.github.io/?730f0c5dc38528a1dd0615f330bd5481

[simonw]

Had Claude Code come up with this devious trick to help auto-close databases in tests:

diff --git a/tests/conftest.py b/tests/conftest.py
index a9a47bc..29a3b16 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -14,6 +14,26 @@ def pytest_configure(config):
     sys._called_from_test = True
 
 
+@pytest.fixture(autouse=True)
+def close_all_databases():
+    """Automatically close all Database objects created during a test."""
+    databases = []
+    original_init = Database.__init__
+
+    def tracking_init(self, *args, **kwargs):
+        original_init(self, *args, **kwargs)
+        databases.append(self)
+
+    Database.__init__ = tracking_init
+    yield
+    Database.__init__ = original_init
+    for db in databases:
+        try:
+            db.close()
+        except Exception:
+            pass
+
+
 @pytest.fixture
 def fresh_db():
     db = Database(memory=True)