Skip to content

fix: make vaadinBuildFrontend build cache relocatable (#25033) (CP: 25.2) - #25035

Merged
vaadin-bot merged 2 commits into
25.2from
cherry-pick-25033-to-25.2-1784786597724
Jul 23, 2026
Merged

fix: make vaadinBuildFrontend build cache relocatable (#25033) (CP: 25.2)#25035
vaadin-bot merged 2 commits into
25.2from
cherry-pick-25033-to-25.2-1784786597724

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #25033 to branch 25.2.

Original PR description

The task cache key embedded absolute project paths, so a shared build cache never hit across checkouts at different locations. Directory inputs no longer contribute their absolute path to the key.

Fixes #25030

The task cache key embedded absolute project paths, so a shared build
cache never hit across checkouts at different locations. Directory
inputs no longer contribute their absolute path to the key.

Fixes #25030
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@vaadin-bot
vaadin-bot enabled auto-merge (squash) July 23, 2026 06:16
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Test Results

 1 456 files  ±0   1 456 suites  ±0   1h 43m 17s ⏱️ - 2m 6s
10 309 tests ±0  10 241 ✅ ±0  68 💤 ±0  0 ❌ ±0 
10 781 runs  ±0  10 712 ✅ ±0  69 💤 ±0  0 ❌ ±0 

Results for commit c6fc526. ± Comparison against base commit 4300712.

♻️ This comment has been updated with latest results.

…table

On 25.2 the default index.html is generated into the frontend root, and
vaadinBuildFrontend declares it as an optional output. When the relocated
copy carries that file, it has no task history in the fresh checkout, so
Gradle treats it as an overlapping output and disables caching - the task
safely rebuilds instead of loading from cache, so the FROM_CACHE assertion
never held.

Omit the generated frontend-root index.html from the relocated copy so the
test exercises only the cache-key fix (no absolute project path in the key).
Its content is not part of the key, so omitting it is safe and it is
restored on the FROM_CACHE hit.
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@sonarqubecloud

Copy link
Copy Markdown

@vaadin-bot
vaadin-bot merged commit e0a6157 into 25.2 Jul 23, 2026
34 checks passed
@vaadin-bot
vaadin-bot deleted the cherry-pick-25033-to-25.2-1784786597724 branch July 23, 2026 09:44
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 25.2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants