-
Notifications
You must be signed in to change notification settings - Fork 609
build: read body response to check for erroneous image export to docker #1927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
util/dockerutil/client.go
Outdated
| prog := progress.WithPrefix(status, "", false) | ||
| progress.FromReader(prog, "importing to docker", resp.Body) | ||
| if err := fromReader(prog, "importing to docker", resp.Body); err != nil { | ||
| discard(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the repro above, it outputs the error in the progress output as expected and w.err is returned with the error on Close():
buildx/util/dockerutil/client.go
Line 116 in b84e0e1
| return w.err |
ExportEntry.Output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened moby/buildkit#4117
caab5a3 to
aae9580
Compare
Signed-off-by: CrazyMax <[email protected]>
aae9580 to
ef4b984
Compare
b97368a to
ef4b984
Compare
|
One way to possibly test this would be to load into something with |
|
Could this also be related to some cases mentioned in this ticket? |
Yes looks to be the same issue |
Uh oh!
There was an error while loading. Please reload this page.