Skip to content

Conversation

@thaJeztah
Copy link
Member

cli/command/stack/*: deprecate exported functions and types

Functions and types in these packages were exported as part of the "compose
on kubernetes" feature, which was deprecated and removed. These functions
are meant for internal use, and will be removed in the next release.

- Human readable description for the release notes

Go SDK: deprecate cli/command/stack/formatter
Go SDK: deprecate cli/command/stack/loader
Go SDK: deprecate cli/command/stack/options
Go SDK: deprecate cli/command/stack/swarm
Go SDK: cli/command/stack: deprecate `RunList`, `RunServices`

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 29.0.0 milestone Aug 28, 2025
@thaJeztah thaJeztah requested review from a team and silvin-lubecki as code owners August 28, 2025 08:21
@thaJeztah thaJeztah added impact/changelog impact/deprecation status/2-code-review kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK process/cherry-pick/28.x labels Aug 28, 2025
Functions and types in this package were exported as part of the "compose
on kubernetes" feature, which was deprecated and removed. These functions
are meant for internal use, and will be removed in the next release.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Functions and types in this package were exported as part of the "compose
on kubernetes" feature, which was deprecated and removed. These functions
are meant for internal use, and will be removed in the next release.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Functions and types in this package were exported as part of the "compose
on kubernetes" feature, which was deprecated and removed. These functions
are meant for internal use, and will be removed in the next release.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Functions and types in this package were exported as part of the "compose
on kubernetes" feature, which was deprecated and removed. These functions
are meant for internal use, and will be removed in the next release.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Functions and types in this package were exported as part of the "compose
on kubernetes" feature, which was deprecated and removed. These functions
are meant for internal use, and will be removed in the next release.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the deprecate_stack_commands branch from 76b2b7b to d16c560 Compare August 28, 2025 08:21
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/stack/services.go 70.00% 3 Missing ⚠️
cli/command/stack/list.go 75.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@vvoland vvoland merged commit 8f25f4f into docker:master Aug 28, 2025
96 checks passed
@thaJeztah thaJeztah deleted the deprecate_stack_commands branch August 28, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code process/cherry-picked status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants