Add confirmation for URL actions #2417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2417 +/- ##
==========================================
- Coverage 28.30% 28.22% -0.08%
==========================================
Files 273 273
Lines 30077 30160 +83
==========================================
Hits 8514 8514
- Misses 21563 21646 +83
|
Member
|
Besides missing tests (not sure how's the criteria we use for that) it looks good to me 👍🏻 |
zacwest
approved these changes
Oct 2, 2023
| } | ||
| } | ||
|
|
||
| private func confirmAction(title: String, message: String, handler: @escaping () -> Void, cancelHandler: (() -> Void)? = nil) { |
Member
There was a problem hiding this comment.
-> Promise<Void> may make the call sites a little easier, e.g.
confirmAction(…).done {
// do the thing
}.catch {
// do an error
}and .cauterize() when we don't care about the error, or in the places right now…
firstly {
confirmAction(…)
}.done {
// rest of the chains
}
Member
|
you'll want to run the linting scripts to make that check happy, at least. code coverage for some of these areas is missing. |
zacwest
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a confirmation for
call_service,fire_eventandsend_location,render_templateurl action.Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes