Conversation
dkotter
previously approved these changes
May 2, 2025
Collaborator
|
Looks like the automated review from the WordPress.org team has flagged issues around ownership. I think this PR addresses everything they're concerned with so would be ideal to get this merged in. @jeffpaul Are we still waiting on this:
|
Member
Author
|
I'd like to get Jobber to provide an email for the CoC; @vikrampm1 mind leaning on Andrew to get that answered so we can add here and get this merged in? (If that drags more than a couple days let's merge here and track that separately as a follow-up item). |
Contributor
|
Here is the email to update: integrations@getjobber.com |
dkotter
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes some issues with displaying Jobber instead of 10up, fixes license references, adds repo badges.
Before merging this in, I'd like to get input from Jobber on what email to properly list here:
jobber-wp/CODE_OF_CONDUCT.md
Line 63 in 2afb994
As those CoC complaints should not come to 10up, but rather Jobber.THIS HAS BEEN UPDATEDHow to test the Change
Most changes can be previewed with a markdown or github previewer.
Changelog Entry
Credits
Props @jeffpaul.
Checklist: