fix: reset tracecontext to avoid unintentional caching#676
Merged
joeyzhao2018 merged 5 commits intomainfrom Sep 30, 2025
Merged
fix: reset tracecontext to avoid unintentional caching#676joeyzhao2018 merged 5 commits intomainfrom
joeyzhao2018 merged 5 commits intomainfrom
Conversation
Member
|
@codex review |
lucaspimentel
approved these changes
Sep 24, 2025
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
Contributor
Author
|
[HOLD] Not merging yet because this seems to be a broader issue if the fix is correct. So we should reproduce first. Trying these now. |
Contributor
Author
|
I could not reproduce. We actually have the exact payload in this customer's case but somehow it's not getting any failure , yet the extracted context is different from the customer's case, which is different from any of the tracecontext propagated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The customer is experiencing a case where multiple lambda invocations are put into one trace even though they have different tracecontext in their payload. This indicates that the
rootTraceContextwas reused/cached unintentionally.Motivation
https://datadoghq.atlassian.net/browse/APMS-17080
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply