feat(debugger): add agent state check to uploader#14653
Conversation
|
|
We add an agent state check to the uploader to allow it to fall back to an appropriate snapshot collection endpoint that is guaranteed to have redaction support. If such guarantees cannot be made we log a warning and disable the uploads of snapshots to prevent sensitive data from being captured.
P403n1x87
force-pushed
the
chore/debugger-agent-check-uploader
branch
from
61d42db to
8bc5007
Compare
P403n1x87
changed the title
Co-authored-by: Tyler Finethy <tylfin@gmail.com>
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 273 ± 5 ms. The average import time from base is: 282 ± 9 ms. The import time difference between this PR and base is: -8.8 ± 0.3 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate chore/debugger-agent-check-uploader (6f316cb) with baseline main (e806495) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 0.408µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.6% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.314µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -2.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.0% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ bytearray_aspectTime: ✅ 1.337µs (SLO: <10.000µs 📉 -86.6%) vs baseline: -0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 1.444µs (SLO: <10.000µs 📉 -85.6%) vs baseline: -2.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 0.610µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 1.296µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -1.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.0% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 1.351µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.9% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1% ✅ bytesio_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.6% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ capitalize_aspectTime: ✅ 0.736µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.9% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 0.435µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ casefold_aspectTime: ✅ 0.738µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.5% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ casefold_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 0.709µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.2% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1% ✅ encode_noaspectTime: ✅ 0.408µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.9% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.450µs (SLO: <10.000µs 📉 -65.5%) vs baseline: +0.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 4.136µs (SLO: <10.000µs 📉 -58.6%) vs baseline: 📈 +13.1% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ format_map_noaspectTime: ✅ 0.781µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.9% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 0.599µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: ~same Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.281µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.9% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 1.366µs (SLO: <10.000µs 📉 -86.3%) vs baseline: +0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ join_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.0% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 2.610µs (SLO: <20.000µs 📉 -86.9%) vs baseline: +0.6% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.2% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.5% ✅ lower_aspectTime: ✅ 2.231µs (SLO: <10.000µs 📉 -77.7%) vs baseline: -0.2% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 2.285µs (SLO: <20.000µs 📉 -88.6%) vs baseline: +0.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.3% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 1.001µs (SLO: <10.000µs 📉 -90.0%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.558µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +1.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.980µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.8% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.203µs (SLO: <10.000µs 📉 -88.0%) vs baseline: -3.4% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.625µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -0.5% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ replace_aspectTime: ✅ 4.902µs (SLO: <10.000µs 📉 -51.0%) vs baseline: -0.6% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 0.459µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.0% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ repr_aspectTime: ✅ 0.906µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.2% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 1.963µs (SLO: <20.000µs 📉 -90.2%) vs baseline: +0.2% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.7% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.444µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 1.683µs (SLO: <10.000µs 📉 -83.2%) vs baseline: +8.4% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 0.722µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 2.289µs (SLO: <20.000µs 📉 -88.6%) vs baseline: +2.3% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 0.389µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +1.7% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 2.505µs (SLO: <10.000µs 📉 -75.0%) vs baseline: +2.8% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 0.542µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +1.0% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 2.332µs (SLO: <10.000µs 📉 -76.7%) vs baseline: -0.7% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 0.504µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 3.299µs (SLO: <10.000µs 📉 -67.0%) vs baseline: +1.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.6% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 2.226µs (SLO: <10.000µs 📉 -77.7%) vs baseline: -0.8% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ upper_noaspectTime: ✅ 0.375µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +2.0% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.372µs (SLO: <10.000µs 📉 -56.3%) vs baseline: +0.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.069µs (SLO: <10.000µs 📉 -89.3%) vs baseline: -0.8% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 6.117µs (SLO: <10.000µs 📉 -38.8%) vs baseline: +1.0% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 2.288µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.954µs (SLO: <10.000µs 📉 -60.5%) vs baseline: 📈 +13.7% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.571µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 5.864µs (SLO: <10.000µs 📉 -41.4%) vs baseline: 📈 +19.2% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 1.594µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.7% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 4.201µs (SLO: <10.000µs 📉 -58.0%) vs baseline: 📈 +12.5% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.695µs (SLO: <10.000µs 📉 -93.0%) vs baseline: ~same Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.596µs (SLO: <10.000µs 📉 -54.0%) vs baseline: -0.6% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.376µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.2% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +4.5% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.119µs (SLO: <20.000µs 📉 -84.4%) vs baseline: -0.7% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 212.224µs (SLO: <250.000µs 📉 -15.1%) vs baseline: +0.4% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 2.908µs (SLO: <20.000µs 📉 -85.5%) vs baseline: -0.3% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 191.855µs (SLO: <220.000µs 📉 -12.8%) vs baseline: +1.3% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.044µs (SLO: <20.000µs 📉 -89.8%) vs baseline: -2.3% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 124.276µs (SLO: <150.000µs 📉 -17.1%) vs baseline: -0.7% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.082µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -1.7% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 213.243µs (SLO: <250.000µs 📉 -14.7%) vs baseline: +0.6% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 100-count-metrics-100-timesTime: ✅ 21.335ms (SLO: <23.500ms -9.2%) vs baseline: ~same Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.019ms (SLO: <2.250ms 📉 -10.3%) vs baseline: +2.2% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.286ms (SLO: <1.550ms 📉 -17.0%) vs baseline: -0.1% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.186ms (SLO: <2.550ms 📉 -14.3%) vs baseline: ~same Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.5% ✅ flush-1-metricTime: ✅ 4.624µs (SLO: <20.000µs 📉 -76.9%) vs baseline: 📈 +12.3% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ flush-100-metricsTime: ✅ 181.764µs (SLO: <250.000µs 📉 -27.3%) vs baseline: +0.4% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.194ms (SLO: <2.500ms 📉 -12.2%) vs baseline: +0.6% Memory: ✅ 32.991MB (SLO: <34.500MB -4.4%) vs baseline: +5.2% 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 28/28✅ appsecTime: ✅ 20.510ms (SLO: <22.300ms -8.0%) vs baseline: ~same Memory: ✅ 65.221MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.349ms (SLO: <1.450ms -7.0%) vs baseline: -0.1% Memory: ✅ 64.330MB (SLO: <67.000MB -4.0%) vs baseline: +5.2% ✅ iastTime: ✅ 20.457ms (SLO: <22.250ms -8.1%) vs baseline: -0.2% Memory: ✅ 65.246MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.244ms (SLO: <16.550ms -7.9%) vs baseline: -0.5% Memory: ✅ 53.340MB (SLO: <54.500MB -2.1%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 26.123ms (SLO: <28.200ms -7.4%) vs baseline: -0.4% Memory: ✅ 67.344MB (SLO: <69.500MB -3.1%) vs baseline: +5.0% ✅ tracerTime: ✅ 20.496ms (SLO: <21.750ms -5.8%) vs baseline: -0.4% Memory: ✅ 65.264MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.093ms (SLO: <23.500ms -6.0%) vs baseline: ~same Memory: ✅ 66.449MB (SLO: <67.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.325ms (SLO: <21.500ms 📉 -10.1%) vs baseline: -0.3% Memory: ✅ 65.275MB (SLO: <66.000MB 🟡 -1.1%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.690ms (SLO: <17.500ms -4.6%) vs baseline: ~same Memory: ✅ 64.998MB (SLO: <66.000MB 🟡 -1.5%) vs baseline: +5.1% ✅ tracer-nativeTime: ✅ 20.559ms (SLO: <21.750ms -5.5%) vs baseline: +0.4% Memory: ✅ 71.034MB (SLO: <72.500MB -2.0%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.459ms (SLO: <19.650ms -6.1%) vs baseline: ~same Memory: ✅ 65.161MB (SLO: <67.000MB -2.7%) vs baseline: +4.7% ✅ tracer-no-databasesTime: ✅ 18.817ms (SLO: <20.100ms -6.4%) vs baseline: ~same Memory: ✅ 64.901MB (SLO: <67.000MB -3.1%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.195ms (SLO: <21.500ms -6.1%) vs baseline: -0.4% Memory: ✅ 65.220MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.403ms (SLO: <22.000ms -7.3%) vs baseline: +0.2% Memory: ✅ 65.286MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.086ms (SLO: <19.850ms -8.9%) vs baseline: +0.4% Memory: ✅ 65.079MB (SLO: <66.500MB -2.1%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.142ms (SLO: <19.400ms -6.5%) vs baseline: +0.4% Memory: ✅ 65.186MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +5.2% ✅ tracer-enabledTime: ✅ 18.157ms (SLO: <19.450ms -6.6%) vs baseline: +0.5% Memory: ✅ 65.018MB (SLO: <66.500MB -2.2%) vs baseline: +5.1% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.043ms (SLO: <47.150ms -4.5%) vs baseline: -0.5% Memory: ✅ 45.045MB (SLO: <47.000MB -4.2%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 324.071ms (SLO: <344.800ms -6.0%) vs baseline: +0.9% Memory: ✅ 554.045MB (SLO: <562.000MB 🟡 -1.4%) vs baseline: +5.1% ✅ add-tagsTime: ✅ 291.567ms (SLO: <314.000ms -7.1%) vs baseline: -0.3% Memory: ✅ 554.111MB (SLO: <563.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ get-contextTime: ✅ 82.917ms (SLO: <92.350ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 40.122MB (SLO: <46.500MB 📉 -13.7%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 43.197ms (SLO: <44.500ms -2.9%) vs baseline: +0.5% Memory: ✅ 44.427MB (SLO: <47.500MB -6.5%) vs baseline: +4.7% ✅ record-exceptionTime: ✅ 62.828ms (SLO: <67.650ms -7.1%) vs baseline: +1.7% Memory: ✅ 40.455MB (SLO: <47.000MB 📉 -13.9%) vs baseline: +4.8% ✅ set-statusTime: ✅ 49.111ms (SLO: <50.400ms -2.6%) vs baseline: +1.1% Memory: ✅ 44.438MB (SLO: <47.000MB -5.5%) vs baseline: +4.7% ✅ startTime: ✅ 42.214ms (SLO: <43.450ms -2.8%) vs baseline: +0.3% Memory: ✅ 44.457MB (SLO: <47.000MB -5.4%) vs baseline: +4.7% ✅ start-finishTime: ✅ 83.039ms (SLO: <88.000ms -5.6%) vs baseline: +0.5% Memory: ✅ 34.544MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 84.494ms (SLO: <89.000ms -5.1%) vs baseline: +0.5% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.9% ✅ update-nameTime: ✅ 44.316ms (SLO: <45.150ms 🟡 -1.8%) vs baseline: +0.1% Memory: ✅ 44.706MB (SLO: <47.000MB -4.9%) vs baseline: +4.9%
|
Small tweak to rate-limit the number of warning logs to at most once an hour. At some point we should also do this for: ``` [DEBUG] ddtrace.internal.remoteconfig.worker: Agent is down or Remote Config is not enabled in the Agent Check your Agent version, you need an Agent running on 7.39.1 version or above. Check Your Remote Config environment variables on your Agent: DD_REMOTE_CONFIGURATION_ENABLED=true ``` Since it's quite noisy as well, but it's behind a DEBUG flag so less important.
tylfin
requested review from
Kyle-Verhoog,
christophe-papazian and
emmettbutler
|
Performing QA on this now:
@P403n1x87 something is going wrong here, what I did was:
This was the last log before the I restarted the latest agent, then no hints from the But heartbeats also permanently stopped if that helps. |
Ah it looks like it got into the absorbing state of having detected an unsupported agent and never trying again 🤔 |
|
Tested manually with various agent failure modes and everything is working 👍 |
…python still valid (#14746) ## Description <!-- Provide an overview of the change and motivation for the change --> Customer reported that a class name changed in the most recent version of ddtrace which was then causing errors when attempting to import `datadog_lambda`. See DataDog/datadog-lambda-python#661 and #14653. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> It's just some tests, so risk is low. ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Added additional tests on the `datadog_lambda` side as well, including running our unit tests twice a day. See DataDog/datadog-lambda-python#662.
3 participants
Description
We add an agent state check to the uploader to allow it to fall back to an appropriate snapshot collection endpoint that is guaranteed to have redaction support. If such guarantees cannot be made we log a warning and disable the uploads of snapshots to prevent sensitive data from being captured.