Remove close prop from button (#198)

[rimildeyjsr]

*remove close prop from button, since it is deprecated
*remove tests checking for unmounting when child with close prop is clicked

Closes #198

Short description

1. Removed the close prop from the button component file.
2. After the removal, 2 tests in the modal component were failing
   • the tests were checking for unmounting when a child component with the close prop was clicked - removed those 2 tests since we are removing the close prop from the button

PR Checklist

• Added tests for bugs / new features
• Updated docs (storybooks, readme)
• Described changes in CHANGELOG.md
• Executed npm run lint and made sure no errors / warnings were shown
• Executed npm run test and made sure all tests are passing
• Bumped version in package.json
• Updated all static build artifacts (npm run build-all)

Versioning

This is a breaking change: the prop has been removed from a component

[gnapse]

@rimildeyjsr this looks good.

I'd take a bit of time to get this merged as I figure out how/when will we release this.

@vishnugopal @henningmu do we have a v6 release in the works? I see we bumped the version to 6 already, but I do not see the release being created yet. Maybe we're on time to add this to the changelog under the latest v6 release and include it there.

I'd ask @rimildeyjsr to add the entry in the changelog but I'm not sure where to put it.

[gnapse]

Update: I'll be approving and merging this, then I'll prepare and create a v6 release to make it all official (the css modules that bumped us to v6 and will include this in that major release).

[rimildeyjsr]

@gnapse - Thank you! 😃

[gnapse]

You're welcome!

BTW, an update on my earlier comment, for the record: I took care of including this in the CHANGELOG and run the build, and make it all part of #275. It was then merged and this is part of the v6 release.