refactor: replace qr-code-styling with smaller library#1129
Merged
abretonc7s merged 6 commits intomainfrom Nov 20, 2024
Merged
Conversation
Collaborator
|
@ecp4224 can you check what's failing on the CI?
|
052e9a3 to
9f854b8
Compare
9f854b8 to
09df87e
Compare
8860807 to
13a3335
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 181 181
Lines 4240 4241 +1
Branches 1042 1042
=======================================
+ Hits 3261 3262 +1
Misses 979 979 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
abretonc7s
approved these changes
Nov 20, 2024
Merged
|
@ecp4224 @abretonc7s fyi styled qr can also be made with new library you’re using, see https://qrbtf.com/en |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Explanation
Replaces the packages
qr-code-stylingwith a smaller QRCode libraryReferences
Before
After
Checklist