Skip to content

refactor: replace qr-code-styling with smaller library#1129

Merged
abretonc7s merged 6 commits intomainfrom
edkek/chore/qrcode-lib-replacement
Nov 20, 2024
Merged

refactor: replace qr-code-styling with smaller library#1129
abretonc7s merged 6 commits intomainfrom
edkek/chore/qrcode-lib-replacement

Conversation

@ecp4224
Copy link
Copy Markdown
Contributor

@ecp4224 ecp4224 commented Nov 15, 2024

Explanation

Replaces the packages qr-code-styling with a smaller QRCode library

References

Before

Screenshot 2024-11-19 at 9 28 37 PM

After

Screenshot 2024-11-19 at 9 09 16 PM

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • [n/a] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@ecp4224 ecp4224 self-assigned this Nov 15, 2024
@ecp4224 ecp4224 requested a review from a team as a code owner November 15, 2024 02:25
@christopherferreira9 christopherferreira9 added the deploy Deploys the test dapps label Nov 15, 2024
@christopherferreira9
Copy link
Copy Markdown
Collaborator

@ecp4224 can you check what's failing on the CI?
Quick questions:

  • this new qr code seems to change the look of the modal increasing its height, is it intended?
  • we're also removing the tiny fox from the qrcode itself, is this intended as well? I'm assuming this alone decreases the bundle?

@ecp4224 ecp4224 force-pushed the edkek/chore/qrcode-lib-replacement branch from 052e9a3 to 9f854b8 Compare November 19, 2024 14:47
@ecp4224 ecp4224 force-pushed the edkek/chore/qrcode-lib-replacement branch from 9f854b8 to 09df87e Compare November 19, 2024 14:48
@ecp4224 ecp4224 force-pushed the edkek/chore/qrcode-lib-replacement branch from 8860807 to 13a3335 Compare November 19, 2024 15:14
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.91%. Comparing base (a9680c5) to head (7cb7c11).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files         181      181           
  Lines        4240     4241    +1     
  Branches     1042     1042           
=======================================
+ Hits         3261     3262    +1     
  Misses        979      979           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sonarqubecloud
Copy link
Copy Markdown

@abretonc7s abretonc7s changed the title Replace qr-code-styling with smaller library refactor: replace qr-code-styling with smaller library Nov 20, 2024
@abretonc7s abretonc7s merged commit 02ed949 into main Nov 20, 2024
@abretonc7s abretonc7s deleted the edkek/chore/qrcode-lib-replacement branch November 20, 2024 02:31
@abretonc7s abretonc7s mentioned this pull request Nov 25, 2024
@paulmillr
Copy link
Copy Markdown

@ecp4224 @abretonc7s fyi styled qr can also be made with new library you’re using, see https://qrbtf.com/en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy Deploys the test dapps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants