Skip to content

Restore GLEW include#2178

Merged
ahojnnes merged 1 commit intocolmap:mainfrom
sarlinpe:paul/fix-glew-includes
Sep 16, 2023
Merged

Restore GLEW include#2178
ahojnnes merged 1 commit intocolmap:mainfrom
sarlinpe:paul/fix-glew-includes

Conversation

@sarlinpe
Copy link
Copy Markdown
Member

Since #2176, building with CUDA_ENABLED=ON GUI_ENABLED=OFF fails due to undfined GL_* symbols:

const int code = sift_gpu_.RunSIFT(bitmap.ScanWidth(),
bitmap.Height(),
bitmap_raw_bits.data(),
GL_LUMINANCE,
GL_UNSIGNED_BYTE);

@ahojnnes
Copy link
Copy Markdown
Contributor

ahojnnes commented Sep 16, 2023

Oh man, thanks. It could be good to have one of the two cuda builds disable the GUI to catch this in CI? Probably the older 20.04 one.

@sarlinpe
Copy link
Copy Markdown
Member Author

Yes!

@ahojnnes ahojnnes merged commit ddc4edb into colmap:main Sep 16, 2023
@sarlinpe sarlinpe deleted the paul/fix-glew-includes branch February 8, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants