Merged
Conversation
sarlinpe
approved these changes
Apr 6, 2025
Contributor
|
Thanks. What if the image ids are not consecutive, where there are some image ids that are not present in the database? |
Contributor
Author
This cannot really happen in the current synthesis (unless the number of outlier reprojections is tuned up significantly). In this case, it would be expected to then also have no matches in the chain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chained match synthesis was meant to work differently than currently implemented, which would create a separate chain per 3D point track. This PR creates a consistent chain across all tracks leading to sufficient matches for downstream tests. Noticed the issue while observing non-deterministic behavior in our e2e pipeline tests depending on order of tests.