Pub/Sub ApiFutures.addCallback() deprecated

[anguillanneuf]

What should people use to add an asynchronous callback on the Api Futures instead now since it's deprecated?

google-cloud-java/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/CreateTopicAndPublishMessages.java

Line 103 in 9cc799f

ApiFutures.addCallback(future, new ApiFutureCallback<String>() {

[vam-google]

You can use

ApiFutures.addCallback(final ApiFuture<V> future, final ApiFutureCallback<? super V> callback, Executor executor)

To get identical behavior to the deprecated method, pass guava's com.google.common.util.concurrent.MoreExecutors.directExecutor() as the last parameter, but please do not do it unless you really know what you are doing. It is better to use separate thread executor, because using direct executor will execute the callback under future's internal locks and may break its behavior if the callback is not properly implemented.

[anguillanneuf]

Thank you! I see the file now:

https://github.com/googleapis/api-common-java/blob/master/src/main/java/com/google/api/core/ApiFutures.java

We should update this sample because it is linked to our docs.