gh-978: Add python.pipenvPath config setting.#3957
Merged
ericsnowcurrently merged 11 commits intomicrosoft:masterfrom Jan 11, 2019
Merged
gh-978: Add python.pipenvPath config setting.#3957ericsnowcurrently merged 11 commits intomicrosoft:masterfrom
ericsnowcurrently merged 11 commits intomicrosoft:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3957 +/- ##
=======================================
- Coverage 78% 78% -<1%
=======================================
Files 406 406
Lines 18852 18861 +9
Branches 3025 3026 +1
=======================================
+ Hits 14577 14578 +1
- Misses 4273 4281 +8
Partials 2 2
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
Jan 10, 2019
DonJayamanne
left a comment
There was a problem hiding this comment.
I'll be merging #3930 shortly, you'll need to modify src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts file as well.
884af91 to
565483b
Compare
Author
|
FYI, I updated the activation provider. |
src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fixes #978)
[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)