Skip to content

InjectExtension: Fix type hint and always executed if.#210

Merged
dg merged 1 commit intonette:masterfrom
janbarasek:janbarasek-inject-extension-fix
Jul 19, 2019
Merged

InjectExtension: Fix type hint and always executed if.#210
dg merged 1 commit intonette:masterfrom
janbarasek:janbarasek-inject-extension-fix

Conversation

@janbarasek
Copy link
Copy Markdown
Contributor

  • bug fix
  • BC break? no

Fix type error and if condition order:

 ------ ---------------------------------------------------------- 
  Line   DI/Extensions/InjectExtension.php                         
 ------ ---------------------------------------------------------- 
  37     Right side of && is always true.                          
  61     Parameter #4 $container of static method                  
         Nette\DI\Extensions\InjectExtension::checkType() expects  
         Nette\DI\Container|Nette\DI\Resolver|null,                
         Nette\DI\ContainerBuilder|null given.                     
 ------ ---------------------------------------------------------- 

@dg dg merged commit edf67d2 into nette:master Jul 19, 2019
@dg
Copy link
Copy Markdown
Member

dg commented Jul 19, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants