Compiler::parseServices: allow prefixing service name in the config

[matej21]

ref nette/docs#377
cc @Majkl578 @greeny

[greeny]

Nice one! 👍

[fprochazka]

Nice!

[dg]

What about something like

services:
    articles: MyBlog\ArticlesModel(@connection)
    comments: MyBlog\CommentsModel(@connection, @self.articles)

[matej21]

@dg maybe it looks a bit better, but this won't work. But it is probably useless anyway.

[dg]

Hmmm, passing service names to methods seems like antipattern.

[matej21]

updated

[dg]

Great!

I'm just not quite sure that self is the best name for this prefix.

[matej21]

I'm not sure either since it is used for self-referencing service.

btw, maybe this could be moved to the ContainerBuilder so you can use @self.foo syntax in the CompilerExtension as well (instead of $this->prefix('@foo'))

[greeny]

btw, maybe this could be moved to the ContainerBuilder so you can use @self.foo syntax in the CompilerExtension as well (instead of $this->prefix('@foo'))

Good idea 👍

What about @this, @current or @scope?

[dg]

btw, maybe this could be moved to the ContainerBuilder so you can use @self.foo syntax in the CompilerExtension as well (instead of $this->prefix('@foo'))

I can imagine that it could cause complications, for example when somebody will addSetup('@self ...') to service from a different scope. In CompilerExtension you need prefix() only in addDefinition().

[dg]

@current, @this and @self sound similary. @scope sound fine, but has a different meaning in DI http://www.javaranch.com/journal/2008/10/dependency-injection-what-is-scope.html.

[dg]

Can you move it bellow next condition?

[matej21]

done

[dg]

Thanks!

[matej21]

great! now I can finally fix the doc :)