Dumper: object hash

[tsusanka]

If Assert:same() is used to compare two similiar-looking objects and the assert fails, the Tester generates two outputs which shows no difference at all.

This PR prints object's hash to distinguish the objects.

[Mikulas]

👍 good idea, I've definitely have seen identical output before and got stuck on it for a while.

Why do you hash the object hash with md5 though?

[dg]

What about non-stdClass objects?

[tsusanka]

@Mikulas I got inspired by Tester's Dumper.php. The sql_object_hash() returns "similiar" content to different objects, so it can't be easily stripped. See function's comment.

@dg this approach should work with non-stdClass objects as well, am I mistaken?

$ php -a
> class A {}
> $a = new A();
> echo spl_object_hash($a);
000000003ae624ea000000003019d5db

[Majkl578]

this approach should work with non-stdClass objects as well

It's in $class === 'stdClass'branch.

[JanTvrdik]

@tsusanka awesome! Maybe return "$class::__set_state(/* #$objHash */ array($out))" for other classes as well.

[tsusanka]

Oh yeah, got it! Fixed.

[milo]

@tsusanka 👍 Could you please:

• separate it e.g. into private static function hash() (the # included in return value)
• squash it into single commit with message like Dumper: print object hash into output dumps

[tsusanka]

Thx for the instructions. Done.

[milo]

@tsusanka Thank you!