Add testcase method's name to the test's title#451
Merged
dg merged 1 commit intonette:masterfrom Jun 18, 2024
Merged
Conversation
d7efad8 to
41a9b32
Compare
9f3ba77 to
7fd3b98
Compare
dg
reviewed
Jun 18, 2024
| { | ||
| $this->file = $file; | ||
| $this->title = $title; | ||
| $this->title = $title !== null ? trim($title) : null; |
Member
There was a problem hiding this comment.
In what case is the constructor called with a title that has extra spaces?
dg
pushed a commit
that referenced
this pull request
Jun 18, 2024
dg
pushed a commit
that referenced
this pull request
Jun 18, 2024
Contributor
Author
|
Thanks for merging 🌻 Unfortunately your changes introduced a minor bug with dealing with spaces in the test's title: 7d226fa#diff-07c33aaa3cca21e4927002dc11edb6d232627948635ad1e537854703ecd21666R231-R233 return array_map(
fn(string $method): Test => $test
->withTitle("$test->title $method")
->withArguments(['method' => $method]),
$methods,
);... If the initial instance of Test doesn't have any "primary" title (i.e. It would probably be sufficient if it was done as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #448.
What this does
For tests wrapped in testcase class:
... where Tester creates a separate
Testobject for each of the testcase's methods, we now add (append) the method's name to the (maybe already specified) test's title.In the case of these two methods, if this PR is merged, the first test object will now have the title
"testMethod_1"and the second one will have the title"testMethod_2".What is looks like
... if Nette Tester self-tests with

-o console-linesoutput mode:Append... title?
Yes, the test file might also contain "a primary, standalone title definition", like so:
... in that case the test objects representing both methods would have a same, pre-specified title
"These are my tests".This PR changes this and in the end the first test object would have the title
"These are my tests testMethod_1"and the second one will have the title"These are my tests testMethod_2".