Skip to content

Update Debugger: apply editor mapping for browser from CLI#477

Merged
dg merged 1 commit intonette:masterfrom
AppsDevTeam:use-editor-mapping-for-browser-path
Apr 6, 2021
Merged

Update Debugger: apply editor mapping for browser from CLI#477
dg merged 1 commit intonette:masterfrom
AppsDevTeam:use-editor-mapping-for-browser-path

Conversation

@thorewi
Copy link
Copy Markdown
Contributor

@thorewi thorewi commented Apr 5, 2021

  • bug fix
  • BC break: no

When opening browser from CLI, editor mappings are not applied.

@dg
Copy link
Copy Markdown
Member

dg commented Apr 6, 2021

Why?

@thorewi
Copy link
Copy Markdown
Contributor Author

thorewi commented Apr 6, 2021

Because the path to the exception file in docker may be (and probably is) different than on the host and then the browser is not opened.

@dg
Copy link
Copy Markdown
Member

dg commented Apr 6, 2021

Ok, thanks

@dg dg changed the title Update Debugger.php Update Debugger: apply editor mapping for browser from CLI Apr 6, 2021
@dg dg merged commit 29110b6 into nette:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants