[stable33] Fix "allow view without download" option not being handled#1387
Merged
[stable33] Fix "allow view without download" option not being handled#1387
Conversation
@nextcloud/initial-state was already an implicit dependency, but now it is made explicit to use the functions it provides in the PDF viewer code. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Since Nextcloud 32 it is possible to enable a general sharing option to allow viewing a document when it is internally shared without download permission. In that case the share attributes still mark the file as not downloadable, even if in practice it is (otherwise it would not be possible to view it locally), so the setting needs to be explicitly taken into account. The setting does not seem to be exposed from the backend, so it is added to the initial state of the PDF viewer to be able to know it. As being able to view a file without download permissions is essentially the same concept as hiding the download in a public share the same limitations are applied too (not allowing to print nor to select). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
backport/1384/stable33
branch
from
6e90e8e to
18e4314
Compare
Member
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1384