chore(queries): avoid left join when possible#3317
Merged
Conversation
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
added
php
artonge
approved these changes
Nov 19, 2025
| ->innerJoin('c', 'photos_albums', 'a', $query->expr()->eq('a.album_id', 'c.album_id')) | ||
| ->where($query->expr()->eq('collaborator_id', $query->createNamedParameter($collaboratorId))) | ||
| ->andWhere($query->expr()->eq('collaborator_type', $query->createNamedParameter($collaboratorType, IQueryBuilder::PARAM_INT))) | ||
| ->andWhere($query->expr()->isNotNull('a.album_id')) |
Collaborator
There was a problem hiding this comment.
Probably a left over from copying and pasting as album_id should always be set in the albums table.
So should be a safe cleanup 👍
| ->selectAlias('a.user', 'album_user') | ||
| ->from('photos_albums_collabs', 'c') | ||
| ->leftJoin('c', 'photos_albums', 'a', $query->expr()->eq('a.album_id', 'c.album_id')) | ||
| ->innerJoin('c', 'photos_albums', 'a', $query->expr()->eq('a.album_id', 'c.album_id')) |
Collaborator
There was a problem hiding this comment.
As said, probably zero impact, as both should always be defined. But at least it is explicit.
| ->from('filecache', 'file'); | ||
| $metadataQuery = $this->filesMetadataManager->getMetadataQuery($qb, 'file', 'fileid'); | ||
| $metadataQuery->joinIndex(PlaceMetadataProvider::METADATA_KEY); | ||
| $metadataQuery->joinIndex(PlaceMetadataProvider::METADATA_KEY, true); |
Collaborator
There was a problem hiding this comment.
As discussed, depending on the DB the optimisation might already be done. But good anyway.
Altahrim
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.