Merged
Conversation
artonge
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
artonge
force-pushed
the
artonge/feat/confirm_album_delete
branch
from
040e1f1 to
481ccea
Compare
skjnldsv
reviewed
Nov 19, 2025
skjnldsv
reviewed
Nov 19, 2025
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
/albums and /sharedalbums should probably be a type instead of hardcoded in many places ;)
Nonetheless, only one slight issue with translations and a secondary question, otherwise good! 👍
artonge
force-pushed
the
artonge/feat/confirm_album_delete
branch
from
481ccea to
6e91c09
Compare
Collaborator
Author
|
/compile rebase / |
nextcloud-command
force-pushed
the
artonge/feat/confirm_album_delete
branch
from
6e91c09 to
402eb5c
Compare
Collaborator
Author
|
/compile rebase / |
Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
artonge/feat/confirm_album_delete
branch
from
402eb5c to
4a2bfe9
Compare
susnux
reviewed
Nov 25, 2025
susnux
reviewed
Nov 25, 2025
susnux
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.