Add LaTex Support#7957

moodyjmz · 2025-11-18T15:11:59Z

📝 Summary

Resolves: Support Latex Math commands #6935

This PR adds LaTeX math support to the text app.

it uses:

Inline typing $…$
Block typing $$…$$
Pasting of inline
Pasting of blocks
Editing of both - I did consider using the same approach as inline links, the bubble, but decided to use the modal approach for both
I added a feature into the menu to change existing content into maths - under the markup section

Code:

I used a factory for making math nodes to avoid duplicating code
It adds a modal, following the pattern of Image

Tests:
It adds some tests covering the features added, and issues I encountered while adding the feature

Limitations:

The existing modal doesn’t appear to be resizable - therefore here is set to largest

🖼️ Screenshots

🏚️ Before	🏡 After

🚧 TODO

...

🏁 Checklist

Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
Sign-off message is added to all commits
Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
Documentation (README or documentation) has been updated or is not required

moodyjmz · 2025-11-18T15:13:28Z

I wanted to see if it would push the expected files - not ready for review yet

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com> feat(:tada:): Make clean branch to avoid pollution from build files in project feat(:wrench:): Update package-lock to be inline with main feat(:wrench:): Update package-lock to be inline with main

moodyjmz · 2025-11-18T16:55:34Z

@max-nextcloud Sorry about the confusion, hopefully this PR is better to check. It only has one commit as I took the files from the other branch.

juliusknorr · 2025-11-18T19:36:09Z

README.md


 Nextcloud Text is the default text editor since Nextcloud 17. To start editing just open an existing markdown or plaintext file or create a new one.

+### Mathematical formulas


So far we do not really have much end user documentation. I'd say we could keep it in here for now still. We probably want this to go to docs.nextcloud.com but just the math section might not be that useful.

@max-nextcloud @mejo- Something we could discuss further as you were thinking about enhancing documentation for collectives, but there may be some overlap with what we could make use of for text itself.

codecov · 2025-11-18T19:36:43Z

Codecov Report

❌ Patch coverage is 58.65385% with 43 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/nodes/MathematicsView.vue	3.84%	20 Missing and 5 partials ⚠️
src/nodes/Mathematics.js	82.35%	11 Missing and 1 partial ⚠️
src/components/Math/ShowMathModal.vue	20.00%	4 Missing ⚠️
src/components/Menu/entries.js	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

package.json

juliusknorr

Very nice, I left one inline comment and there are two CI checks that need some more work to pass.

When testing the modal seems to have an issue with not taking up the full height of the textarea, but I'm unsure if that is a component issue or could be addressed here as well. Would be fine to track as a follow up for polishing:

juliusknorr · 2025-11-18T19:56:13Z

Also cc @marcoambrosini for a design review

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>

…thing and not removed Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>

moodyjmz · 2025-11-18T21:32:45Z

Very nice, I left one inline comment and there are two CI checks that need some more work to pass.

When testing the modal seems to have an issue with not taking up the full height of the textarea, but I'm unsure if that is a component issue or could be addressed here as well. Would be fine to track as a follow up for polishing:

Thanks :)

I addressed those issues.

Yes, the modal, I was unsure what caused it, but felt it was out of scope to address in this PR.

mejo- · 2025-11-24T10:23:20Z

@moodyjmz thanks a lot for the contribution, much appreciated ❤️

I just reviewed the PR (was on vacation last week) and realized that it adds @tiptap/extension-mathematics as NPM dependency but doesn't actually use it. I guess that it's a leftover from your development process? Also, looking at the upstream @tiptap/extension-mathematics code I wondered what was the reason why you decided to implement the whole mathematics node type yourself instead of using and extending the upstream @tiptap/extension-mathematics one 😊

moodyjmz · 2025-11-24T10:43:35Z

@moodyjmz thanks a lot for the contribution, much appreciated ❤️

I just reviewed the PR (was on vacation last week) and realized that it adds @tiptap/extension-mathematics as NPM dependency but doesn't actually use it. I guess that it's a leftover from your development process? Also, looking at the upstream @tiptap/extension-mathematics code I wondered what was the reason why you decided to implement the whole mathematics node type yourself instead of using and extending the upstream @tiptap/extension-mathematics one 😊

@mejo- You are right about the npm dependency - that shouldn't be there. I looked at callouts.js for guidance and followed that. I'm not sure how many changes would be needed to use the tiptap approach, although that is likely a better implementation and reduces maintenance overhead. I can see, looking at other files, that tiptap extensions are extended from elsewhere.

moodyjmz · 2025-11-24T11:50:10Z

@mejo- Removing the dependency is easy. However, I would say it should be used instead. However this also raises the question of backward compatibility - if this feature is implemented differently in terms of processing to/from markdown than what is already there - this needs to be determined. Based on that, then the amount of changes can be determined. Is this feature already in the in the wild?

mejo- · 2025-11-24T11:57:25Z

@moodyjmz thanks a lot for considering my concerns. I agree that we should use the upstream Tiptap extension and expand on it in case we need extra functionality. The toMarkdown() functions need to be added for sure, and if we still want/need the custom NodeView representation, then the NodeView vue file as well.

I just opened #7977 to track follow-up topics for this PR. If you don't mind, we can move the conversation there.

github-actions · 2025-12-03T02:15:22Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

moodyjmz requested review from max-nextcloud and mejo- as code owners November 18, 2025 15:12

moodyjmz marked this pull request as draft November 18, 2025 15:12

moodyjmz force-pushed the feat/latex-math-clean branch from 9eaa0ee to 533af02 Compare November 18, 2025 16:50

moodyjmz marked this pull request as ready for review November 18, 2025 16:54

juliusknorr added enhancement New feature or request 3. to review labels Nov 18, 2025

juliusknorr self-requested a review November 18, 2025 19:33

juliusknorr reviewed Nov 18, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

juliusknorr reviewed Nov 18, 2025

View reviewed changes

juliusknorr requested a review from marcoambrosini November 18, 2025 19:55

moodyjmz added 3 commits November 18, 2025 20:57

fix(:art:): Update code styling to match prettier

f03fc29

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>

fix(:art:): :memo: Update readme to match prettier style

4bf2ec7

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>

chore(:wrench:): :fire: Remove sass-embedded - was added to test some…

8d381b5

…thing and not removed Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>

moodyjmz force-pushed the feat/latex-math-clean branch from 0d8e038 to 8d381b5 Compare November 18, 2025 19:59

chore(::page_facing_up:): Add missing license to maths files

8b7c90b

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>

moodyjmz changed the title ~~WIP: Add LaTex Support~~ Add LaTex Support Nov 19, 2025

juliusknorr approved these changes Nov 19, 2025

View reviewed changes

juliusknorr merged commit 31af010 into nextcloud:main Nov 19, 2025
64 checks passed

juliusknorr mentioned this pull request Nov 19, 2025

LaTeX formula modal is cut off #7961

Closed

mejo- mentioned this pull request Nov 24, 2025

Bugs with new mathematics node types #7977

Closed

github-actions bot added the feedback-requested label Dec 3, 2025

mejo- mentioned this pull request Feb 17, 2026

Feature Request: Mathoid Integration for Proper LaTeX Formula Rendering nextcloud/collectives#2272

Closed


		Nextcloud Text is the default text editor since Nextcloud 17. To start editing just open an existing markdown or plaintext file or create a new one.

		### Mathematical formulas

Conversation

moodyjmz commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

🖼️ Screenshots

🚧 TODO

🏁 Checklist

Uh oh!

moodyjmz commented Nov 18, 2025

Uh oh!

moodyjmz commented Nov 18, 2025

Uh oh!

juliusknorr Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

juliusknorr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Nov 18, 2025

Uh oh!

moodyjmz commented Nov 18, 2025

Uh oh!

Uh oh!

mejo- commented Nov 24, 2025

Uh oh!

moodyjmz commented Nov 24, 2025

Uh oh!

moodyjmz commented Nov 24, 2025

Uh oh!

mejo- commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

moodyjmz commented Nov 18, 2025 •

edited

Loading

codecov bot commented Nov 18, 2025 •

edited

Loading

juliusknorr left a comment •

edited

Loading

mejo- commented Nov 24, 2025 •

edited

Loading