Update maths to use tiptap vs custom implementation for latex#7978
Conversation
|
@mejo- I think this should address the issues you mentioned, sans the inline menu question |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
d0fd0be to
fd51ee4
Compare
fd51ee4 to
a558595
Compare
|
For some reason some playwright tests fail reliably now 🤔 |
…g pattern Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: Jonas <jonas@freesources.org>
Fixes opening the smart picker when typing `/`. Signed-off-by: Jonas <jonas@freesources.org>
a558595 to
cd165ff
Compare
Found the reason and pushed a fix. the When CI runs through now I will merge. Thanks again @moodyjmz for the contribution, much appreciated 🙏 |
|
That's great! Thanks for finding the issue and fixing it |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
📝 Summary
Summary
Migrated the mathematics nodes to use the official @tiptap/extension-mathematics package instead of our custom
implementation. This brings us in line with Tiptap while maintaining all existing functionality.
Changes Made
Core Migration
Backward Compatibility
$E=mc^2$gets converted to KaTeX HTML by markdown-itBug Fixes
<span ref="mathEl"> </span>that was causing line breaksMenu Updates
math_inline>>>inlineMath,math_block>>>blockMathTests
What Still Works
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)