Conversation
Altahrim
force-pushed
the
chore/update-dev-deps
branch
4 times, most recently
from
b2b8424 to
6616d4c
Compare
Altahrim
changed the title
Altahrim
force-pushed
the
chore/update-dev-deps
branch
2 times, most recently
from
c2193fa to
109f5b9
Compare
skjnldsv
approved these changes
Nov 4, 2025
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
chore/update-dev-deps
branch
from
109f5b9 to
8175818
Compare
come-nc
reviewed
Nov 10, 2025
| private function moveWithExclusions(string $dataLocation, array $excludedElements): void { | ||
| foreach ($this->getRecursiveDirectoryIterator($dataLocation, $excludedElements) as $path => $fileInfo) { | ||
| if ($dataLocation === '') { | ||
| throw new \Exception('Invalid dataLocation procided'); |
| [$this->configValues] = $this->readConfigFile(); | ||
|
|
||
| if (php_sapi_name() !== 'cli' && ($this->configValues['upgrade.disable-web'] ?? false)) { | ||
| if (php_sapi_name() !== 'cli' && ($this->configValues['upgrade.disable-web'] ?? false) !== true) { |
Member
There was a problem hiding this comment.
Suggested change
| if (php_sapi_name() !== 'cli' && ($this->configValues['upgrade.disable-web'] ?? false) !== true) { | |
| if (php_sapi_name() !== 'cli' && ($this->configValues['upgrade.disable-web'] ?? false)) { |
| [$this->configValues] = $this->readConfigFile(); | ||
|
|
||
| if (php_sapi_name() !== 'cli' && ($this->configValues['upgrade.disable-web'] ?? false)) { | ||
| if (php_sapi_name() !== 'cli' && ($this->configValues['upgrade.disable-web'] ?? false) !== true) { |
Member
There was a problem hiding this comment.
Suggested change
| if (php_sapi_name() !== 'cli' && ($this->configValues['upgrade.disable-web'] ?? false) !== true) { | |
| if (php_sapi_name() !== 'cli' && ($this->configValues['upgrade.disable-web'] ?? false)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.