Skip to content

chore: dependency review config#1556

Merged
aphralG merged 2 commits intomainfrom
chore/dependency-review-config
Mar 12, 2026
Merged

chore: dependency review config#1556
aphralG merged 2 commits intomainfrom
chore/dependency-review-config

Conversation

@oCHRISo
Copy link
Copy Markdown
Collaborator

@oCHRISo oCHRISo commented Mar 11, 2026

Proposed changes

Upgrading dependency-review-action and having our own dependency config instead of using nginx/k8s-common

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

oCHRISo added 2 commits March 11, 2026 09:44
- Copy dependency-review-config.yml from nginx/k8s-common into .github/
- Add MPL-2.0 to allow_licenses
- Update dependency-review workflow to reference local config instead of remote
@oCHRISo oCHRISo requested a review from a team as a code owner March 11, 2026 09:48
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 11, 2026
@oCHRISo oCHRISo changed the title Chore/dependency review config chore: dependency review config Mar 11, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.02%. Comparing base (ba1de47) to head (5bdd59b).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage   85.02%   85.02%           
=======================================
  Files         103      103           
  Lines       13589    13589           
=======================================
  Hits        11554    11554           
  Misses       1518     1518           
  Partials      517      517           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1de47...5bdd59b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Apache-2.0
- BSD-2-Clause
- BSD-3-Clause
- BSL-1.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might still need to add "Apache-2.0 AND BSD-3-Clause" for Agent.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this PR comment separate lines should be ok
https://github.com/nginx/k8s-common/pull/109/changes

@Akshay2191 Akshay2191 self-requested a review March 12, 2026 08:54
@aphralG aphralG merged commit 288df05 into main Mar 12, 2026
160 of 190 checks passed
@aphralG aphralG deleted the chore/dependency-review-config branch March 12, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants