lookup: skip s390 and ppc for react#754
Merged
targos merged 1 commit intonodejs:masterfrom Oct 21, 2019
andrewhughes101:lookup
Merged
lookup: skip s390 and ppc for react#754targos merged 1 commit intonodejs:masterfrom andrewhughes101:lookup
targos merged 1 commit intonodejs:masterfrom
andrewhughes101:lookup
Conversation
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 27 27
Lines 879 879
=======================================
Hits 839 839
Misses 40 40Continue to review full report at Codecov.
|
richardlau
approved these changes
Oct 21, 2019
BethGriggs
approved these changes
Oct 21, 2019
targos
approved these changes
Oct 21, 2019
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #754 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 27 27
Lines 879 879
=======================================
Hits 839 839
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React's failing on ppc and s390. The issue seems to be that it tries to download electron and there are no pre-compiled binaries of electron for these platforms.
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/
Checklist
npm testpasseshere