Merged
Conversation
currently just checks if global bin is in $PATH
Collaborator
|
no statistically significant performance changes detected timing results
|
Member
Author
|
I can edit this to include docs once we've bikeshed the subcommand names. |
fritzy
reviewed
Nov 30, 2022
fritzy
left a comment
There was a problem hiding this comment.
Looks good so far. We can bikeshed the subcommand name next standup.
Usage is driven by actual code, commands are tagged for grouping
a6066ec to
bf7fb3b
Compare
nlf
approved these changes
Dec 6, 2022
Contributor
nlf
left a comment
There was a problem hiding this comment.
unless there are objections, i think this makes sense to me. the groupings are named well enough to be intuitive.
Member
Author
|
Please squash this one when merging. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed output to display as each check finishes instead of all at once at the end.
Check added:
checkBinPath. Checks that the global bin is in your path.Added grouping to commands.