Fix deadlock in LRUCache and improve test coverage#1000
Merged
davidism merged 3 commits intopallets:masterfrom Oct 4, 2019
Merged
Fix deadlock in LRUCache and improve test coverage#1000davidism merged 3 commits intopallets:masterfrom
davidism merged 3 commits intopallets:masterfrom
Conversation
EtiennePelletier
force-pushed
the
fix_deadlock_improve_tests
branch
2 times, most recently
from
0bdfed9 to
1dae748
Compare
kevin-brown
previously requested changes
Jun 7, 2019
davidism
force-pushed
the
fix_deadlock_improve_tests
branch
from
73866b2 to
70fefa5
Compare
setdefault was acquiring write_lock, then calling getitem and also potentially setitem, which also both try to acquire the write lock.
davidism
force-pushed
the
fix_deadlock_improve_tests
branch
from
70fefa5 to
69d8d98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was adding tests for Undefined and other utils by running coverage and finding which lines did not have test coverage, then I found there is a deadlock bug in the LRUCache's setdefault method.
As documented in the commit: setdefault was acquiring write_lock, then calling getitem and also
potentially setitem, which both try to acquire the write lock.
Minimal snippet to reproduce the bug with Python 3.7.3 and Jinja 2.10.1:
It's fixed now and we have better test coverage 😄