Use separate undefined object for else-less conditional expressions#1079
Merged
davidism merged 2 commits intopallets:masterfrom Oct 13, 2019
Merged
Use separate undefined object for else-less conditional expressions#1079davidism merged 2 commits intopallets:masterfrom
davidism merged 2 commits intopallets:masterfrom
Conversation
ThiefMaster
commented
Oct 12, 2019
Member
|
Do we need this to be configurable? It seems like the contract of |
Member
Author
|
That was my question ;) Then I'll change the default to use the |
ThiefMaster
force-pushed
the
cond-expr-undefined
branch
2 times, most recently
from
47bad3e to
28b848b
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
oh, I think I misread your comment, i thought you mean that it's supposed to return the |
ThiefMaster
force-pushed
the
cond-expr-undefined
branch
from
28b848b to
c4d3996
Compare
ThiefMaster
force-pushed
the
cond-expr-undefined
branch
from
1a2ec72 to
4d331a0
Compare
davidism
approved these changes
Oct 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #710