bpo-45506: Normalize _PyPathConfig.stdlib_dir when calculated.#29040
bpo-45506: Normalize _PyPathConfig.stdlib_dir when calculated.#29040ericsnowcurrently merged 18 commits intopython:mainfrom
Conversation
gpshead
left a comment
There was a problem hiding this comment.
./python -m test.regrtest test_embed -v still fails in an out of tree build for me with this change. As does test_gdb. Both appear to be having trouble importing encodings? Others such as test_importlib no longer fail.
|
When you're done making the requested changes, leave the comment: |
|
I ran the full test suite: |
warsaw
left a comment
There was a problem hiding this comment.
Even with this PR, test_embed and test_unittest still fail.
|
Hmm, I don't get failures in test_unittest. At this point, I've fixed the problem with test_embed and only need to deal with failures in subprocess due to that first commit. |
|
With that latest commit I got all the tests to pass in an out-of-tree build. |
This comment has been minimized.
This comment has been minimized.
gpshead
left a comment
There was a problem hiding this comment.
I believe this one is good. test_embed still fails for me using this branch but I think there was another PR you already merged that addressed that.
|
@ericsnowcurrently: Please replace |
The recently added
PyConfig.stdlib_dirwas being set with ".." entries. When__file__was added for from modules this caused a problem on out-of-tree builds. This PR fixes that by normalizing "stdlib_dir" when it is calculated in getpath.c.https://bugs.python.org/issue45506