Help tabs broken & lots of scripts missing

[jrfnl]

Hiya,

I love the idea of this plugin. Unfortunately it's not working as advertised if used on the WordPress back-end.

Issue 1:

If this plugin is activated the help tab functionality in the back-end of WordPress breaks.
You can open the help tab and the first section will display, but if you click on any of the other sections, the help text will not change.
Some other functionality might also break, depending on which plugins are installed.

Issue 2 (very likely related):

The plugin calls the $wp_scripts->do_items() method which actually causes the script queue to be printed. That can't be the intention. Those scripts are not meant to be printed at that point of generating the html page.
Have a look at the page source code of any back-end page to see what I mean, you will see script tags in your table.

Issue 3:

Any scripts which are queued to be loaded in the footer are not included in the output.
Have a look at the 'New post' page for example. You will see lots of scripts (and some stylesheets) at the bottom of the html source. These are not listed on the debug bar scripts/styles panel.

I thought I'd debug and send you a pull request, unfortunately the problems are larger than I expected and I don't have time at this moment to dive in too deeply.

My current line of thinking on how to actually get this to work properly is something along the lines of the following:

• at tab rendering, just render a nearly empty page
• hook into the enqueue function to register which scripts are being queued (or maybe hook into the do_items function ?) or any logical other place where you can find the scripts being requested. I'm not sure which hook are available for this, needs some research.
• save the result to a transient
• request the transient via ajax when the script/styles panel of the debug bar is requested.

Not sure if this is actually the way to go, but something surely needs to be changed.

Hope this helps and please let me know if you need more information.

Smile,
Juliette

[soderlind]

Hi Juliette,

Thank you for catching this and for reporting it in a very thorough report :) I'll dive into the code and fix the bug (most likely rewrite the plugin).

Thanks,
Per

[jrfnl]

Excellent! Thanks. I look forward to it ;-)

[soderlind]

Fixed, please test

[soderlind]

Btw, the fix was simple (it usually is), just had to read and understand WP_Scripts. The handle for loaded scripts are stored in $wp_scripts->done and $wp_scripts->in_footer (css are in $wp_styles->done) , in the order they are loaded, so I replaced $wp_scripts->do_items() with:

foreach ( array_merge($wp_scripts->done, $wp_scripts->in_footer) as $loaded_scripts) {
    /*
    do stuff
    */
}

[jrfnl]

Hi Per,

Glad to hear it turned out to be so simple & thanks for your quick response!

I've been testing it on a few pages and it definitely is better than it was before!

1. The help tabs issue = fixed
2. The loading of the scripts in the middle of your table = fixed
3. not 100% right yet, some scripts are listed twice (easily fixed), but I'm also still getting inconsistent results for both the scripts and the styles listings - especially with the scripts, quite a few are still missing.

The reason for this is most likely that the admin bar on the back-end is loaded quite early on and some core/plugin methods may still queue scripts for loading in the footer after the admin bar has already been send to the screen.
While on the front-end this isn't an issue as the admin bar is loaded last.

Also - like you (I saw the commented out code), I like to verify with the file source path. I figured more people might find that useful as the names aren't always very descriptive, so I've made some changes to your code to incorporate this in a non-obtrusive way.
And while I was at it, I've made some small css/styling adjustments.
I'll send you a pull request in a moment.

For point three, below are some screenshots of what I mean - I've tried to highlight the issues with color indicators.

Hope this helps!

Smile,
Juliette

Double listed scripts on front end page (fix included in my pull request)

Firebug stylesheet listing versus plugin - Admin Dashboard page

Firebug scripts listing versus plugin - Admin Dashboard page

[soderlind]

Fixed, see: #2

[jrfnl]

Please reopen - my pull request only fixes the duplicate script listings (screenshot 1).

It does not fix the missing scripts/styles in the listings on the back-end (screenshots 2/3/4/5)